Repository navigation
feat: rp login prompts for the api key instead of polling - #675
Merged
Merged
Conversation
rp login creates the auth request and opens the approval url as before, then reads the key from a hidden prompt, checks it with a myself query, and saves it. Up to three attempts; non-TTY stdin fails fast and points to RUNPOD_API_KEY or --api-key.
marie-karpinska
force-pushed
the
mariekarpinska/sls-626-login-paste
branch
from
November 2, 2026 22:52
9de6167 to
f23403f
Compare
jasonwang-runpod
approved these changes
Nov 2, 2026
Promptless documentation updates
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rp loginnow reads the API key from the user. After browser approval, the console shows the key andrp loginasks for it with a hidden prompt, verifies it withmyself, and saves it.--api-keyand--profilework as before.Note for reviewers
verify_api_keytreats anyQueryErroras a rejected key, so a server-side GraphQL failure shows as "api key was rejected". Should we split those?How I tested
make test-coveragepasses (1540 tests, coverage 91.99%)uv run pytest tests/test_apps/test_auth.py tests/test_apps/test_api_client.py tests/test_cli/test_management_commands.pypasses (122 tests), including a check that the pasted key does not appear in CLI outputuvx black --checkon the changed files reports only formatting that is also flagged on origin/mainecho "" | uv run rp login --no-openexits 1 with the interactive-terminal message