Skip to content

Add omniauth_oidc GHSA-xgh2-jgvm-8g78 - #1263

Merged
jasnow merged 3 commits into
rubysec:masterfrom
msuliq:omniauth_oidc-GHSA-xgh2-jgvm-8g78
Oct 26, 2026
Merged

jasnow merged 3 commits into
rubysec:masterfrom
msuliq:omniauth_oidc-GHSA-xgh2-jgvm-8g78

Conversation

@msuliq

@msuliq msuliq commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Adds GHSA-xgh2-jgvm-8g78 for omniauth_oidc. I am the gem's maintainer.

omniauth_oidc 1.0.0 and 1.0.1 accept unsigned ID tokens (alg: none) when client_signing_alg is not configured, which allows an authentication bypass in the response_type: "id_token" flow. Fixed in 1.1.0. Versions before 1.0.0 are not affected.

The GitHub advisory is published; no CVE has been assigned yet. bundle exec rspec and yamllint gems rubies pass locally.

Prepared with Claude Code and reviewed by me.

* Unsigned ID tokens (alg none) accepted in omniauth_oidc 1.0.0
  and 1.0.1 for the id_token flow; fixed in 1.1.0

@jasnow jasnow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Change CHANGELOG URL to
- https://github.com/msuliq/omniauth_oidc/blob/main/CHANGELOG.md#110---2026-10-14

Add this to URL list
- GHSA-xgh2-jgvm-8g78

Add this to end of file
notes: |

  • No CVE
  • cvss_v3 from GHSA URL.

* Link CHANGELOG to the 1.1.0 section
* Add GitHub advisory database URL to related urls
* Add notes on missing CVE and cvss_v3 source

@jasnow jasnow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnow
jasnow requested a review from simi October 14, 2026 15:37
@jasnow

jasnow commented Oct 18, 2026

Copy link
Copy Markdown
Member

Ready for review

@jasnow
jasnow merged commit 04bbdae into rubysec:master Oct 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants