Repository navigation
Use MinGW prefix known by Ruby to convert MSYS2 paths - #59
Merged
Merged
Conversation
We used the prefix of the native pkg-config to convert MSYS2 paths such as /mingw64/include to Windows paths. But pkg-config may not be installed or may be MSYS's one such as /usr/bin/pkgconf. In the case, MSYS2 paths weren't converted. Ruby knows the Windows path of the MinGW prefix: RubyInstaller provides it and MSYS2's Ruby is installed into it. See also: https://github.com/groonga/groonga/actions/runs/43796618836/job/133066762726 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used the prefix of the native pkg-config to convert MSYS2 paths such as /mingw64/include to Windows paths. But pkg-config may not be installed or may be MSYS's one such as /usr/bin/pkgconf. In the case, MSYS2 paths weren't converted.
Ruby knows the Windows path of the MinGW prefix: RubyInstaller provides it and MSYS2's Ruby is installed into it.
See also: https://github.com/groonga/groonga/actions/runs/43796618836/job/133066762726