Skip to content

fix: restore workspace tests and pin the CodSpeed runner - #11

Merged
intellild merged 1 commit into
masterfrom
codex/fix-ci-and-workspace-tests
Oct 26, 2026
Merged

intellild merged 1 commit into
masterfrom
codex/fix-ci-and-workspace-tests

Conversation

@intellild

@intellild intellild commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Fix the test and CI failures on the existing master package layout. This PR targets master directly and does not include the crate renaming or workspace publishing migration in #10.

The pinned CodSpeed runner rejects Ubuntu 26.04, which ubuntu-latest now selects. Pin that job to its supported ubuntu-24.04 image.

Restore workspace tests and address verified lint issues:

  • Extend the selectors test parser to recognize the pseudo-elements its assertions exercise.
  • Balance Bloom benchmark insertions and removals to prevent debug counter underflow; make the compile-time storage assertion safe.
  • Disable the Node addon's empty Rust test harness, which cannot link without Node runtime symbols, and keep registered JS callback wrappers private.
  • Replace the copied, obsolete NAPI example with documentation of the internal helper's actual API.
  • Accept either order of equivalent conditions merged by parallel imports. For example, (color: red) or (foo: bar) and its reverse are equivalent; the rest of each snapshot remains exact.
  • Apply compiler-verified lint cleanups in helpers, bindings, examples, and tests.

Validation on this branch, without the package-renaming changes:

  • Workspace Rust tests with all stable-compatible features: 195 passed.
  • Nightly selectors tests with all features: 12 passed. The pre-existing ignored documentation snippet remains ignored.
  • Workspace Clippy with all targets and stable-compatible features: passed under default rules; existing style warnings remain and strict -D warnings is not clean.
  • Native yarn build, 81 JS tests, and TypeScript checks: passed.
  • Formatting and diff checks: passed.

The CodSpeed runner itself still needs validation on GitHub's Ubuntu runner; the local host is a different distribution.

The two PRs both target master directly. A trial merge found overlapping textual edits in c/src/lib.rs, napi/src/lib.rs, node/src/lib.rs, and selectors/attr.rs; after either PR merges, the later merge must retain both the crate paths and the test/lint fixes.


by OpenAI Codex

@codspeed

codspeed Bot commented Oct 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing codex/fix-ci-and-workspace-tests (5dc165c) with master (a3cf0d9)2

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on master (492f267) during the generation of this report, so a3cf0d9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@intellild
intellild marked this pull request as ready for review October 26, 2026 10:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T11:00:16.158343Z 5dc165c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@intellild
intellild merged commit e9e68ea into master Oct 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant