You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: restore workspace tests and pin the CodSpeed runner - #11
Fix the test and CI failures on the existing master package layout. This PR targets master directly and does not include the crate renaming or workspace publishing migration in #10.
The pinned CodSpeed runner rejects Ubuntu 26.04, which ubuntu-latest now selects. Pin that job to its supported ubuntu-24.04 image.
Restore workspace tests and address verified lint issues:
Extend the selectors test parser to recognize the pseudo-elements its assertions exercise.
Balance Bloom benchmark insertions and removals to prevent debug counter underflow; make the compile-time storage assertion safe.
Disable the Node addon's empty Rust test harness, which cannot link without Node runtime symbols, and keep registered JS callback wrappers private.
Replace the copied, obsolete NAPI example with documentation of the internal helper's actual API.
Accept either order of equivalent conditions merged by parallel imports. For example, (color: red) or (foo: bar) and its reverse are equivalent; the rest of each snapshot remains exact.
Apply compiler-verified lint cleanups in helpers, bindings, examples, and tests.
Validation on this branch, without the package-renaming changes:
Workspace Rust tests with all stable-compatible features: 195 passed.
Nightly selectors tests with all features: 12 passed. The pre-existing ignored documentation snippet remains ignored.
Workspace Clippy with all targets and stable-compatible features: passed under default rules; existing style warnings remain and strict -D warnings is not clean.
Native yarn build, 81 JS tests, and TypeScript checks: passed.
Formatting and diff checks: passed.
The CodSpeed runner itself still needs validation on GitHub's Ubuntu runner; the local host is a different distribution.
The two PRs both target master directly. A trial merge found overlapping textual edits in c/src/lib.rs, napi/src/lib.rs, node/src/lib.rs, and selectors/attr.rs; after either PR merges, the later merge must retain both the crate paths and the test/lint fixes.
No successful run was found on master (492f267) during the generation of this report, so a3cf0d9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the test and CI failures on the existing
masterpackage layout. This PR targetsmasterdirectly and does not include the crate renaming or workspace publishing migration in #10.The pinned CodSpeed runner rejects Ubuntu 26.04, which
ubuntu-latestnow selects. Pin that job to its supportedubuntu-24.04image.Restore workspace tests and address verified lint issues:
(color: red) or (foo: bar)and its reverse are equivalent; the rest of each snapshot remains exact.Validation on this branch, without the package-renaming changes:
-D warningsis not clean.yarn build, 81 JS tests, and TypeScript checks: passed.The CodSpeed runner itself still needs validation on GitHub's Ubuntu runner; the local host is a different distribution.
The two PRs both target
masterdirectly. A trial merge found overlapping textual edits inc/src/lib.rs,napi/src/lib.rs,node/src/lib.rs, andselectors/attr.rs; after either PR merges, the later merge must retain both the crate paths and the test/lint fixes.by OpenAI Codex