Repository navigation
Conversation
When a thread other than the leader execs, its first frame under the leader's tid is the execve's exit. Replay moved its task to that tid only when it replayed that frame, so until then current_task() found no task: gdb continuing over such an exec made rr abort in require_timeline_current_task(), and `rr replay -a -t` stepping across it crashed. Move the task when replay reads that frame. Test: continue_exec_from_other_thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Patch/test by AI. Part of the exec handling series]
When a thread other than the leader execs, its first frame under the leader's tid is the execve's exit. Replay moved its task to that tid only when it replayed that frame, so until then current_task() found no task: gdb continuing over such an exec made rr abort in require_timeline_current_task(), and
rr replay -a -tstepping across it crashed. Move the task when replay reads that frame.Test: continue_exec_from_other_thread.