Repository navigation
Conversation
At a restart_syscall entry, rr set the task's syscall number back to the interrupted syscall's, so the kernel ran that syscall again from the start: relative sleeps and timeouts started over after every signal without a handler, and a restart that a signal handler had cancelled ran the syscall again instead of failing with EINTR. Put that number only in the recorded registers, so emulated ptracers see restart_syscall at the entry, as natively. Test: restart_syscall_sleep, ptrace_restart_syscall. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Encountered, debugged, patch, test by AI. Part of a series of 5 patches around restart handling. Note that this follows up on #4142 which was the same issue for syscalls interrupted by a signal handler. This is the case where the signal is ignored]
At a restart_syscall entry, rr set the task's syscall number back to the interrupted syscall's, so the kernel ran that syscall again from the start: relative sleeps and timeouts started over after every signal without a handler, and a restart that a signal handler had cancelled ran the syscall again instead of failing with EINTR. Put that number only in the recorded registers, so emulated ptracers see restart_syscall at the entry, as natively.
Test: restart_syscall_sleep, ptrace_restart_syscall.