Repository navigation
Restore a failed syscall's mutated input where it overlaps an OUT one - #4161
Merged
rocallahan merged 1 commit intoNov 20, 2026
Merged
Conversation
faa0a52 ("Don't write back OUT parameters for failed syscalls") meant to restore the original contents of a mutated input parameter where it overlaps an OUT parameter of a failed syscall, but tested the mutated parameter's mode instead of the OUT parameter's. So e.g. a failing rt_sigprocmask() whose old set is its new set kept rr's change to the new set, which rr no longer recorded, and replay diverged. Test: sigprocmask_evil. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AI noticed this while rebasing on recent master commits]
faa0a52 ("Don't write back OUT parameters for failed syscalls") meant to restore the original contents of a mutated input parameter where it overlaps an OUT parameter of a failed syscall, but tested the mutated parameter's mode instead of the OUT parameter's. So e.g. a failing rt_sigprocmask() whose old set is its new set kept rr's change to the new set, which rr no longer recorded, and replay diverged.
Test: sigprocmask_evil.