Skip to content

Restore a failed syscall's mutated input where it overlaps an OUT one - #4161

Merged
rocallahan merged 1 commit into
rr-debugger:masterfrom
ChronitonAI:mutated-arg-failed-out
Nov 20, 2026
Merged

rocallahan merged 1 commit into
rr-debugger:masterfrom
ChronitonAI:mutated-arg-failed-out

Conversation

@Keno

@Keno Keno commented Nov 18, 2026

Copy link
Copy Markdown
Member

[AI noticed this while rebasing on recent master commits]

faa0a52 ("Don't write back OUT parameters for failed syscalls") meant to restore the original contents of a mutated input parameter where it overlaps an OUT parameter of a failed syscall, but tested the mutated parameter's mode instead of the OUT parameter's. So e.g. a failing rt_sigprocmask() whose old set is its new set kept rr's change to the new set, which rr no longer recorded, and replay diverged.

Test: sigprocmask_evil.

faa0a52 ("Don't write back OUT parameters for failed syscalls") meant
to restore the original contents of a mutated input parameter where it
overlaps an OUT parameter of a failed syscall, but tested the mutated
parameter's mode instead of the OUT parameter's. So e.g. a failing
rt_sigprocmask() whose old set is its new set kept rr's change to the
new set, which rr no longer recorded, and replay diverged.

Test: sigprocmask_evil.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rocallahan
rocallahan merged commit ff43c9e into rr-debugger:master Nov 20, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants