Repository navigation
Detach a ptracer's emulated tracees when the ptracer exits - #4160
Merged
rocallahan merged 1 commit intoNov 18, 2026
Merged
Conversation
Linux detaches a ptracer's tracees when the ptracer thread exits. rr did that only in ~RecordTask, which for a thread-group leader whose process lives on comes much later, and without resuming a tracee it held at a clone, fork, vfork or exec event stop. Recording then hung, or failed with "Unhandled ptrace event" or "Exiting an execve we didn't know about". Detach the tracees when we handle the ptracer's exit, and resume a tracee we hold at an event stop with the code that resumes it for PTRACE_CONT. Test: ptracer_death_event_stop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Encountered/debugged/patch/test by AI]
Linux detaches a ptracer's tracees when the ptracer thread exits. rr did that only in ~RecordTask, which for a thread-group leader whose process lives on comes much later, and without resuming a tracee it held at a clone, fork, vfork or exec event stop. Recording then hung, or failed with "Unhandled ptrace event" or "Exiting an execve we didn't know about". Detach the tracees when we handle the ptracer's exit, and resume a tracee we hold at an event stop with the code that resumes it for PTRACE_CONT.
Test: ptracer_death_event_stop.