Repository navigation
Keep a forked child's rr buffers where its parent's were - #4159
Merged
Merged
Conversation
A forked child starts with a copy of its parent's address space, including the parent's scratch memory and syscall buffer. rr mapped new ones for the child elsewhere, and they could land in a range the parent had marked MADV_DONTFORK, which the child expects to be unmapped (madvise_dontfork failed intermittently). Now the child uses the copied scratch memory, in recording and replay, and maps its syscall buffer over the copied one. Older rr can't replay such traces: it maps new memory over the copied scratch memory, which the child may be running on (e.g. after a fork in the syscall hook). So bump FORWARD_COMPATIBILITY_VERSION, and add a trace quirk so that rr replays older traces as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[This fixes intermittent CI failures in madvise tests on master. It additionally stops previous rr mappings from leaking in forked children, which is a minor cleanup. However, to do this properly, we need to change the replay logic for these mappings, requiring a FORWARD_COMPATIBILITY_VERSION. I do think this is better, but if that bump is undesirable, we could relax the tests instead of fix the intermittent failure. Patch by AI after debugging the intermittent CI failure]
A forked child starts with a copy of its parent's address space, including the parent's scratch memory and syscall buffer. rr mapped new ones for the child elsewhere, and they could land in a range the parent had marked MADV_DONTFORK, which the child expects to be unmapped (madvise_dontfork failed intermittently). Now the child uses the copied scratch memory, in recording and replay, and maps its syscall buffer over the copied one.
Older rr can't replay such traces: it maps new memory over the copied scratch memory, which the child may be running on (e.g. after a fork in the syscall hook). So bump FORWARD_COMPATIBILITY_VERSION, and add a trace quirk so that rr replays older traces as before.