Repository navigation
Conversation
EventHandler::take_data() takes the event into the callback's argument type. The test's callback took an int, so rmw wrote an 8-byte rmw_offered_deadline_missed_status_t into a 4-byte int: a stack-buffer-overflow found with AddressSanitizer, on both Fast DDS and Cyclone DDS. Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
mjcarroll
force-pushed
the
mjcarroll/test-qos-event-callback-type
branch
from
November 10, 2026 01:53
4bf6b4c to
fbe13b5
Compare
ABI Compliance Check✅ Verdict: compatible
✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test fix:
TestQosEvent.executeused anintcallback, sotake_data()had rmw write an 8-bytermw_offered_deadline_missed_status_tinto 4 bytes. The callback now takesQOSDeadlineOfferedInfo.Is this user-facing behavior change?
No.
Did you use Generative AI?
Claude Code (Claude Opus 5.5) found this under ASan and wrote the change; I reviewed it.
Additional Information