Repository navigation
Fix shell detection with multiline commands in thisroot.sh - #23937
Open
guitargeek wants to merge 1 commit into
Open
guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
A newline in a shell argument makes cut return text from later lines. This can select the wrong setup path and leave `ROOTSYS` unset. Read the first line after converting the NUL separators to newlines. Keep reading the stream so long commands also work with pipefail. Fixes root-project#23746
2 tasks done
Test Results 22 files 22 suites 3d 10h 39m 24s ⏱️ For more details on these failures, see this check. Results for commit 4dd8745. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A newline in a shell argument makes cut return text from later lines. This can select the wrong setup path and leave
ROOTSYSunset.Read the first line after converting the NUL separators to newlines. Keep reading the stream so long commands also work with pipefail.
Fixes #23746