Skip to content

feat(babel): support rollup 5 - #2039

Open
lukastaegert wants to merge 2 commits into
masterfrom
babel-rollup-5
Open

lukastaegert wants to merge 2 commits into
masterfrom
babel-rollup-5

Conversation

@lukastaegert

@lukastaegert lukastaegert commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Rollup Plugin Name: babel

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes
  • no

Breaking Changes?

  • yes
  • no

List any relevant issue numbers:

Description

In #2035, I found out that the babel plugin does not actually work with its minimally declared rollup version 2.0.0 as it relies on object-form plugin hooks that were introduced in 2.78.0. At the same time, no additional changes are needed to support rollup 5.

This PR adjusts both in a way that mirrors #2037.

Test against rollup@5.0.0-2 through the rollup-next catalog. The test assertions are version-aware and shared with #2035.

To test plugins against the upcoming Rollup 5 release.
Raise the declared peer floor to 2.78.0, the first Rollup version that supports object-form plugin hooks, and extend the range to Rollup 5.
@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Reviews (1) · Last reviewed commit: "feat(babel): support rollup 5" · Reviewed by Greptile

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Babel’s build and pretest commands now use Rollup 5, which requires Node >=22.22.0, while existing CI jobs still run them on unsupported Node 20.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

Prepares @rollup/plugin-babel for Rollup 5 as part of the wider plugin compatibility work, while correcting its declared minimum Rollup version.

Changes:

  • Adds Rollup 5 to the peer dependency range and raises the Rollup 2 minimum to 2.78.0.
  • Switches Babel’s development dependency to the shared rollup-next catalog.
  • Makes test expectations version-aware for warnings, chunk hashes, and output interop.
File Description
pnpm-workspace.yaml Defines the Rollup 5 prerelease catalog.
pnpm-lock.yaml Locks Rollup 5 and its associated dependencies.
packages/​babel/​test/​as-output-plugin.mjs Adapts warning and chunk-hash expectations across versions.
packages/​babel/​test/​as-input-plugin.mjs Adapts unresolved-import warnings and explicitly sets interop.
packages/​babel/​package.json Updates supported Rollup versions and selects the new catalog.

Review effort: Balanced

"@rollup/plugin-node-resolve": "^15.0.0",
"@types/babel__core": "^7.1.9",
"rollup": "^4.0.0-24",
"rollup": "catalog:rollup-next",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants