Repository navigation
Conversation
profiling
force-pushed
the
profiling/issue-82-upstream-failure-logs
branch
from
November 19, 2026 09:46
60b0860 to
35d9861
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 98.40% 98.48% +0.07%
==========================================
Files 9 9
Lines 5085 5415 +330
==========================================
+ Hits 5004 5333 +329
- Misses 81 82 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
profiling
force-pushed
the
profiling/issue-82-upstream-failure-logs
branch
from
November 19, 2026 09:59
c7f6b91 to
2cc06d2
Compare
profiling
marked this pull request as draft
November 19, 2026 11:36
profiling
force-pushed
the
profiling/issue-82-upstream-failure-logs
branch
2 times, most recently
from
November 19, 2026 15:35
9018da2 to
629db79
Compare
profiling
marked this pull request as ready for review
November 19, 2026 15:36
A failed clone or fetch was only counted under repo="-"; callers logged the outer error without git's diagnostic, and a client disconnect was not logged at all. Log the final failure where the operation, repo and credential are known, with a bounded, redacted stderr summary, and drop the duplicate. Refs rolandjitsu#82 Assisted-by: Claude:claude-opus-5-5
A client going away or shutdown is not an upstream failure. Assisted-by: Claude:claude-opus-5-5
Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Summary
Closes #82. Logs each upstream clone/fetch failure once, with the repo, an
error_kind, and a redacted summary of the git stderr. Cancelled operations (client gone, or shutdown) are no longer counted as upstream errors.Open questions:
clientcredential mode, each upstream auth rejection logs a warn. Keep warn, or use info?BREAKING CHANGEfooter?Tests
Checklist
cargo fmt --all --check,cargo clippy --all-targets --all-features --locked -- -D warnings,cargo test --all-featuresAssisted-by:trailer (see CONTRIBUTING.md / AGENTS.md)Breaking change?
upstream_ops_total{result="error"}no longer counts cancelled operations.