Repository navigation
Allow install scripts and fix clipped search titles - #217
Merged
Merged
Conversation
npm 12 skips dependencies' install scripts unless package.json allows them in an allowScripts field, and newer npm 11 releases, such as the 11.19 that the workflows use, warn about every install script the field doesn't cover. Without their scripts, gifsicle, jpegtran-bin and optipng-bin never download the programs that gulp-imagemin runs, so with npm 12, gulp bundle fails at the image step. The field, written with npm install-scripts approve and deny, allows those three packages' scripts, pinned to the installed versions, which are the newest that the imagemin plugins here accept. It denies the scripts of es5-ext, which only prints a message when it's installed in a Russian time zone, and of fsevents, which is installed only on macOS and which the build doesn't use: without it, gulp's file watcher falls back to Node's own. Older versions of npm ignore the field. Installed with npm 11.12, 11.19 and 12, the bundle comes out the same as before.
Contributor
|
UI bundle preview build successful! ✅ |
This comment has been minimized.
This comment has been minimized.
In the search dialog, a result title too long for its row was cut off mid-letter, which happens mostly on phones. DocSearch's styles set text-overflow on the row, but the title and the snippet under it are flex items, which that setting doesn't reach. The snippet already has its own overflow rules, and the title now gets the same ones, so it ends with an ellipsis instead. Nothing else changes. With the rule added to the dialog on docs.datastax.com, screenshots of a search on a desktop are identical, and on a phone only the ends of the long titles change.
Contributor
|
UI bundle preview build successful! ✅ |
|
Build successful! ✅ |
eric-schneider
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes:
gulp bundle: gifsicle, jpegtran-bin and optipng-bin never download the image optimizers that gulp-imagemin runs. This adds anallowScriptsfield that allows those three scripts, pinned to the current versions, and denies the scripts of es5-ext and fsevents, which the build doesn't need. It also clears the install-scripts warning that npm 11.19 prints in the workflows. Older versions of npm ignore the field.