Repository navigation
fix(rwi): start talk time when an originate is answered - #308
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A call started with
call.originatereportsduration_secs: 0in itscall_hangupevent, however long the callee talked.The session's hangup duration comes from
meta.answer_time. Inbound calls set it inaccept_call, but the originate path attaches the answered dialog throughattach_caller_dialogand never sets it, so the duration falls back to 0. CDRs are unaffected because the originate task tracks its own answer time.This sets
answer_timeinattach_caller_dialogwhen it is still empty.Test:
rwi_originate_attach_starts_talk_timeattaches an answered originate dialog and checks that talk time has started. It fails without the change.