Repository navigation
Don't end macro recording on a q that is another key's argument - #282
Merged
nightwing merged 1 commit intoNov 1, 2026
Merged
Conversation
While recording, every `q` ended the recording, even when a pending key was waiting for it as its argument: `fq`, `tq`, `"qp`, `@q`, a text object's `iq`. Vim ends the recording only on a `q` that is a command of its own. The check now looks at the key buffer: an empty buffer, or a count only, means the `q` is a command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W2aBHqJtz3wmW7kAdNmsYS
nightwing
approved these changes
Nov 1, 2026
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While recording a macro, every
qends the recording, including aqthat a pending key is waiting for as its argument:fq,tq,"qp,@q, or a text object'siq. Soqa f q x qstops recording at thef q, and the register holds justf.Vim ends the recording only on a
qthat is a command of its own. The check now looks at the key buffer: aqends the recording when the buffer is empty or holds only a count.Test.
macro_q_as_argument_does_not_end_recordingrecordsf q xand replays it. It fails without the change, and the full suite passes with it.🤖 Generated with Claude Code
https://claude.ai/code/session_01W2aBHqJtz3wmW7kAdNmsYS