Repository navigation
fix: Incorrect icon for Unknown sync status - #312
Open
keithchong wants to merge 1 commit into
Open
keithchong wants to merge 1 commit into
keithchong wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Collaborator
Author
|
@aali309 could you please review this |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 11.30% 14.16% +2.85%
==========================================
Files 169 192 +23
Lines 6679 7535 +856
Branches 2235 2441 +206
==========================================
+ Hits 755 1067 +312
- Misses 5923 6467 +544
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong
force-pushed
the
bug-IncorrectIconForSyncStatus
branch
from
November 2, 2026 17:26
4957801 to
25669e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No Jira. Found this while testing. The current icon is spinning, which is wrong. It should just be an empty circle just like for a resource with no health status.