Repository navigation
eslint-local-rules: harden inline highlight parsing (non-greedy regex, per-group JSON validation) - #8715
Open
nextjohnp7 wants to merge 7 commits into
Open
eslint-local-rules: harden inline highlight parsing (non-greedy regex, per-group JSON validation)#8715nextjohnp7 wants to merge 7 commits into
nextjohnp7 wants to merge 7 commits into
Conversation
- Add node_modules/.bin executable wrappers for acorn, eslint, browserslist, js-yaml, json5, semver, and other CLI tools - Create .package-lock.json to manage npm dependency resolution and integrity hashes for the local rules plugin - Include standard Node.js shebangs and entry points for all added binary scripts to ensure correct execution context
Update from task 2c24b9a8-a9c6-47a3-97bb-02a6e28370b6
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
… deps - Replace greedy INLINE_HIGHLIGHT_REGEX with a non-greedy global regex and validate each [[...]] group independently (per-group JSON parsing). - Declare the runtime dependencies actually required by the local rules (eslint, remark@12, @babel/core, @babel/parser, babel-plugin-react-compiler) so tests run on a clean install. - Add nested-highlight fixture and test asserting valid nested arrays pass. - Drop accidentally committed node_modules and restore .gitignore/yarn.lock.
Update from task 2c24b9a8-a9c6-47a3-97bb-02a6e28370b6
…tion - Refactor `eslint-local-rules/rules/inline-highlights.js` to use a strict, non-greedy regex for detecting inline highlight markers. - Implement robust JSON parsing logic that validates per-group metadata structure before processing highlights. - Update `.gitignore` to exclude lock files (`package-lock.json`, `yarn.lock`) while retaining `node_modules` exclusion.
Update from task 2c24b9a8-a9c6-47a3-97bb-02a6e28370b6
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.