Repository navigation
Scroll SectionList viewability test past clipped bounds - #59572
Merged
Merged
Conversation
Summary: Scroll the horizontal viewability flow to Brownie before asserting that Cheesecake appears in the callback output. Android accessibility bounds are clipped to the viewport, so Maestro can report 100% visibility while Cheesecake is still partly off screen. Revealing the following item brings Cheesecake fully inside the viewport without weakening the viewability assertion or changing its timeout. Changelog: [Internal] Differential Revision: D128053674
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128053674. |
Collaborator
|
This pull request was successfully merged by @javache in 29636a2 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Scroll the horizontal viewability flow to Brownie before asserting that Cheesecake appears in the callback output. Android accessibility bounds are clipped to the viewport, so Maestro can report 100% visibility while Cheesecake is still partly off screen. Revealing the following item brings Cheesecake fully inside the viewport without weakening the viewability assertion or changing its timeout.
Changelog: [Internal]
Differential Revision: D128053674