Skip to content

Fix Hermes configuration after the source directory changes #59514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shamilovtim wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Fix Hermes configuration after the source directory changes #59514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,18 @@ fun buildHermesCCommandLineArgs() = listOf(
ndkBuildJobs,
)

// CMake caches contain absolute paths. Clear them only when Gradle runs configuration again.
fun CustomExecTask.clearCMakeCacheBeforeConfigure(hermesBuildDir: File) {
doFirst {
File(hermesBuildDir, "CMakeCache.txt").delete()
File(hermesBuildDir, "CMakeFiles").deleteRecursively()
}
}

val configureBuildForHermes by
tasks.registering(CustomExecTask::class) {
dependsOn(installCMake)
clearCMakeCacheBeforeConfigure(hermesBuildDir)
workingDir(hermesDir)
inputs.dir(hermesDir)
outputs.files(hermesBuildOutputFileTree)
Expand Down Expand Up @@ -240,6 +249,7 @@ val buildHermesLib by
val configureBuildForHermesWithDebugger by
tasks.registering(CustomExecTask::class) {
dependsOn(installCMake)
clearCMakeCacheBeforeConfigure(hermesBuildDir)
workingDir(hermesDir)
inputs.dir(hermesDir)
outputs.files(hermesBuildOutputFileTree)
Expand Down
Loading