Repository navigation
Conversation
The WM8960 codec was missing regulator supply definitions and DAPM routes required for proper microphone bias handling, resulting in excessive capture noise and poor wake-word detection on Raspberry Pi 4 running LineageOS. - Define all five WM8960 regulator supplies, mapping the digital rails to 3.3 V and speaker rails to 5 V. - Add the missing MICB dependency routes to both left and right boost mixers so DAPM correctly manages the microphone bias generator. These changes improve the captured signal-to-noise ratio and microphone reliability for the Waveshare WM8960 sound card. Refs: raspberrypi#4384 Signed-off-by: Peter Meiser <peter.meiser@gmx.com>
meiser79
force-pushed
the
waveshare-wm8960-fixes
branch
from
October 26, 2026 08:53
68c58ce to
136fa4d
Compare
Contributor
|
The change to the regulator declarations might save a few warnings about using dummy regulators, which is good, but it will have no practical impact on sound quality on a Raspberry Pi (beyond the placebo effect); the 3.3V and 5V regulators are purely software constructs - fancy wrappers around the numbers 3.3 and 5 - because the rails can't be switched on and off. The other change sounds more plausible, like it might actually cause a change in the WM8960 configuration. Any comments, @waveshare? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WM8960 codec was missing regulator supply definitions and DAPM routes required for proper microphone bias handling, resulting in excessive capture noise and poor wake-word detection on Raspberry Pi 4 running LineageOS.
These changes improve the captured signal-to-noise ratio and microphone reliability for the Waveshare WM8960 sound card.
Refs: #4384