Repository navigation
Use the target Python version when selecting benchmarks - #506
Open
savannahostrowski wants to merge 1 commit into
Open
savannahostrowski wants to merge 1 commit into
savannahostrowski wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a bug where benchmark selection checks
requires-pythonagainst the interpreter running pyperformance, rather than the target specified by--python.I noticed this while investigating benchmark coverage for https://doesjitgobrrr.com/. Sulaco’s results include eight
async_tree_eager*benchmarks missing from Ripley’s results. Their harnesses run 3.12 and 3.11 respectively, despite both targeting CPython’smainbranch.This PR uses the target interpreter’s version for filtering and adds a regression test.