Repository navigation
Conversation
* Add a note about the goal of FromUnion * A note about property * Some "open questions" notes about intersections and GetMemberType
Documentation build overview
7 files changed ·
|
| which would require some more careful thought to specify. | ||
|
|
||
| * Would adding intersection types conflict with any of this, if they | ||
| are added? Would it be sufficient to add ``FromIntersection`` to |
Member
There was a problem hiding this comment.
I think this has the same problems Carl and I flagged about unions, only worse because intersections simplify much more often. Does FromIntersection[int & str] give you (int, str) or Never (since int & str = Never)?
Contributor
Author
There was a problem hiding this comment.
Alright I dropped the call for FromIntersection, and I updated FromUnion to call for simplifying unions but not for interchanging between bool and Literal[True, False] or similar.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a note about the goal of FromUnion
A note about property
Some "open questions" notes about intersections and GetMemberType
Change is either:
PR title prefixed with PEP number (e.g.
PEP 123: Summary of changes)