Repository navigation
gh-161179: Fix function names in os.{spawnve,preadv}() and tkinter.wm_attributes() error messages - #161180
Merged
Conversation
… wm_attributes() os.spawnve() said "spawnv()" when the first element of argv is empty, os.preadv() said "preadv2()" when buffers is not a sequence, and tkinter's wm_attributes() said "wm_attribute()" when options are given both positionally and as keywords. Add tests checking the messages.
|
All commit authors signed the Contributor License Agreement. |
StanFromIreland
approved these changes
Nov 2, 2026
StanFromIreland
changed the title
os.{spawnve,preadv}() and tkinter.wm_attributes() error messages
StanFromIreland
enabled auto-merge (squash)
November 2, 2026 20:45
StanFromIreland
added
needs backport to 3.14
|
Thanks @thejesh23 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161210 is a backport of this pull request to the 3.15 branch. |
|
GH-161211 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three error messages named the wrong function:
os.spawnve()saidspawnv()when the first element of argv is empty.os.preadv()saidpreadv2()when buffers is not a sequence (os.pwritev()already sayspwritev()).tkinterwm_attributes()saidwm_attribute()when options are given both positionally and as keywords.The
argument_unavailable_error("preadv2", "flags")call inos.preadv()is left alone, since it names the underlying syscall on purpose.Tests check each corrected message with
assertRaisesRegex. Thespawnvetest only runs whereos.spawnv()is the native C function (Windows), the same skiptest_spawnv_arg_conversion_errorsuses.AI disclosure: prepared with the help of Claude Code; I reviewed the change and the test results.