Skip to content

gh-159612: Remove macOS x86_64 from tail-call CI due to LLVM timeouts #160713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StanFromIreland merged 1 commit into from
Oct 26, 2026
+2 −11
Merged

gh-159612: Remove macOS x86_64 from tail-call CI due to LLVM timeouts #160713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions .github/workflows/tail-call.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,9 @@ env:

jobs:
macos:
name: ${{ matrix.target }}
runs-on: ${{ matrix.runner }}
name: aarch64-apple-darwin/clang
runs-on: macos-26
timeout-minutes: 60
strategy:
fail-fast: false
matrix:
include:
- target: x86_64-apple-darwin/clang
runner: macos-26-intel
- target: aarch64-apple-darwin/clang
runner: macos-26
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand All @@ -49,7 +41,6 @@ jobs:
- name: Build
run: |
export SDKROOT="$(xcrun --show-sdk-path)"
export PATH="/usr/local/opt/llvm@${{ env.LLVM_VERSION }}/bin:$PATH"
export PATH="/opt/homebrew/opt/llvm@${{ env.LLVM_VERSION }}/bin:$PATH"
CC=clang-${{ env.LLVM_VERSION }} ./configure --with-tail-call-interp

@hugovk hugovk Oct 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer need to use Homebrew clang for tail-call builds since the current Xcode-supplied tools chains are based on LLVM 21. That's what we use for macOS installer builds with tail-call. I think it's fine to remove this CI testing for Intel Macs as it is a tier-2 platform. But I also would like to see removing the use of Homebrew clang for macOS. AFAIK, the only configuration where Homebrew clang is currently needed is for the specific case of generating the JIT templates, not for building Python itself.

So remove the "Install dependencies" step? And in this step delete the two exports and change configure to something like CC=clang ./configure --with-tail-call-interp?

@ned-deily ned-deily Oct 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the two exports should no longer be needed. But, presumably we want to be testing with all of the third-party libs installed? In that case, Homebrew is still needed for those but they may be already installed as part of the image but may need to be updated. Ideally, the build part of the workflow should be the same as reusable-macos.yml except for the --with-tail-call-interp. Or perhaps we no longer need to test both options in CI, just always with --with-tail-call-interp?

make all --jobs 4
Expand Down
Loading