Repository navigation
gh-160697: Process the QSBR queue from the eval breaker, not from _PyMem_FreeDelayed()
#160698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Eclips4
wants to merge
1
commit into
python:main
Choose a base branch
from
Eclips4:ft-free-delayed-reentrancy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import threading | ||
| import unittest | ||
|
|
||
| from test.support import threading_helper | ||
|
|
||
|
|
||
| class Holder: | ||
| pass | ||
|
|
||
|
|
||
| def make_shared(func, *args): | ||
| t = threading.Thread(target=func, args=args) | ||
| t.start() | ||
| t.join() | ||
|
|
||
|
|
||
| @threading_helper.requires_working_threading() | ||
| class TestDelayedFreeReentrancy(unittest.TestCase): | ||
| ROUNDS = 1000 | ||
|
|
||
| def queue_finalizers(self, callback): | ||
| class Finalizer: | ||
| def __del__(self): | ||
| callback() | ||
|
|
||
| holders = [Holder() for _ in range(self.ROUNDS)] | ||
| for h in holders: | ||
| h.__dict__ = {"f": Finalizer()} | ||
| return holders | ||
|
|
||
| def test_dict_resize(self): | ||
| d = {} | ||
| make_shared(d.get, 0) | ||
| holders = self.queue_finalizers(lambda: d.__setitem__(object(), 0)) | ||
| for n, h in enumerate(holders): | ||
| h.__dict__ = {} | ||
| if n % 2: | ||
| h.__dict__ = {} | ||
| for k in list(d): | ||
| del d[k] | ||
| for i in range(6): | ||
| d[i] = i | ||
| self.assertEqual(len(d), len(list(d))) | ||
|
|
||
| def test_list_resize(self): | ||
| L = [] | ||
| make_shared(L.append, 0) | ||
| holders = self.queue_finalizers(L.clear) | ||
| for n, h in enumerate(holders): | ||
| h.__dict__ = {} | ||
| if n % 2: | ||
| h.__dict__ = {} | ||
| L.clear() | ||
| for i in range(9): | ||
| L.insert(len(L), i) | ||
| self.assertEqual(len(L), len(list(L))) | ||
|
|
||
| def test_type_cache_invalidation(self): | ||
| class C: | ||
| x = None | ||
|
|
||
| holders = self.queue_finalizers(lambda: C.x) | ||
| for h in holders: | ||
| h.__dict__ = {} | ||
| C.x | ||
| new = object() | ||
| C.x = new | ||
| self.assertIs(C.x, new) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Core_and_Builtins/2026-10-26-10-18-26.gh-issue-160697.qSbR1f.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Fix crashes and hangs in the :term:`free-threaded build` when a destructor | ||
| ran in the middle of a :class:`dict` resize, a :class:`list` resize or a type | ||
| cache update. The thread's queue of delayed frees is now processed only from | ||
| the eval breaker, instead of synchronously when the queue fills up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type cache is unfortunately affected too.