Repository navigation
[3.15] gh-160513: Call connection_lost() when start_tls() handshake is lost (GH-160514) - #160686
Merged
Merged
Conversation
… lost (pythonGH-160514) SSLProtocol.connection_lost() did not notify the application protocol while a handshake was in progress, even when start_tls() had handed over a protocol that had already seen connection_made(). With streams this left StreamWriter.wait_closed() waiting forever. ANT-2026-A6ZIAFVT ANT-2026-4SKWM05E (cherry picked from commit d9cfd30) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
miss-islington
requested review from
1st1,
asvetlov,
gpshead,
kumaraditya303,
picnixz and
willingc
as code owners
October 25, 2026 23:25
This was referenced Oct 25, 2026
gpshead
enabled auto-merge (squash)
October 25, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSLProtocol.connection_lost() did not notify the application protocol
while a handshake was in progress, even when start_tls() had handed
over a protocol that had already seen connection_made(). With streams
this left StreamWriter.wait_closed() waiting forever.
ANT-2026-A6ZIAFVT
ANT-2026-4SKWM05E
(cherry picked from commit d9cfd30)
Co-authored-by: Gregory P. Smith 68491+gpshead@users.noreply.github.com
start_tls()does not callconnection_lost()when the handshake is aborted #160513