Repository navigation
gh-150582: Use _winapi for _pyrepl console handles and waits - #150584
Merged
Merged
Conversation
8 tasks
Member
|
LGTM! Will let the pyrepl maintainers do the merge (looks like the CI failures are unrelated, and pretty sure they have fixes in progress). |
|
This PR is stale because it has been open for 90 days with no activity. |
chris-eibl
approved these changes
Sep 11, 2026
Member
|
LGTM, too.
cc @ambv / @pablogsal |
Member
Author
|
Hi @zooba @chris-eibl, I think this PR is small and only affects Windows. Could we go ahead and merge it if @ambv and @pablogsal don't have time to review it? |
Member
|
Yupp, let's go. At Europython, I spoke with @ambv, and he's okay with me merging PRs like this one. |
Member
|
Merged, @aisk thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_pyrepl#150582