Repository navigation
Release completed keyed partition state - #503
Open
akshitkhokhani wants to merge 1 commit into
Open
akshitkhokhani wants to merge 1 commit into
akshitkhokhani wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyed
partitioncurrently leaves completed keys in_bufferand_metadata_buffer; it also retains timer entries for batches that scheduled a timeout. A long-lived stream therefore keeps per-key bookkeeping for every distinct completed key.Remove those entries before delivering the completed batch. Removing them before awaiting downstream work lets a new batch for the same key retain its own buffers and timer. Batch contents and the stream's existing latest-value behavior are unchanged. This is separate from the
partition_uniquemetadata-reference work in #502.Validation on macOS ARM64, Python 3.13.7, pinned upstream
5267116f49fc2257e39b44abd8d1e5c5460715f8:streamz/tests/test_core.py: 129 passed, 2 skipped.flake8 streamzandgit diff --checkpass.Tests use small synthetic inputs in a local checkout with networking denied. The full optional-integration suite and other Python/platform combinations were not run.
AI disclosure: prepared and tested with Codex under the account owner's authorization, with independent review by a separate Codex agent. No human review is claimed.