Repository navigation
Validate LocalToField offsets during construction - #944
Closed
Narek-Khachikyan wants to merge 1 commit into
Closed
Narek-Khachikyan wants to merge 1 commit into
Narek-Khachikyan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Editor integrations construct LocalToField to decide whether to offer the refactoring. Invalid targets currently pass construction and fail only when get_changes() runs.
Validate eligibility in the constructor and reuse the resolved name for conversion. Reject unresolved names and builtins with RefactoringError before reading their definition locations.
Fixes #927.
The constructor tests have 7 failures and 3 passes before the fix, then all 10 pass on Python 3.11, 3.13, and 3.14. The full suite passes on Python 3.13 with 2,173 passed, 7 skipped, and 5 expected failures. Local full-suite runs on Python 3.11 and 3.14 encounter interpreter-related fixture errors. Pre-commit and the package build pass.
Checklist