Repository navigation
Import default dependencies when inlining across modules - #942
Closed
Narek-Khachikyan wants to merge 1 commit into
Closed
Narek-Khachikyan wants to merge 1 commit into
Narek-Khachikyan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inlining a method into another module could insert a default such as
sys.maxsizewithout importingsys, causing aNameError. Collect and rewrite imports from parameter defaults as well as the method body. Temporary assignments preserve multiline and string defaults.Fixes #743
The executable regression failed with
NameErrorbefore the fix and now returns the expected result. Validation: 105 inline tests passed; the full suite had 2,172 passed, 7 skipped, and 5 expected failures. Black and isort checks passed.Checklist