Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The public
.valueview drops earlier array-of-tables elements when unrelated headers split their declaration:This also makes the document compare unequal to its own
unwrap()result. Combine the fresh lists produced byAoT.valuewhile merging out-of-order dictionary views. Ordinary formatted arrays retain their existing wrapper and behavior.Validation on Windows / CPython 3.12.10: all four new split-AoT regression cases fail against the original source; all 1,229 tests pass with this change. Ruff lint/format and
git diff --checkpass, and mypy reports the same 33 baseline diagnostics. A separate Codex agent checked 97 document tests, 96 additional cases, repeated-read isolation, and ordinary-array identity. Six scalar-table timing comparisons remained within about 4% of the baseline.Duplicate Check
Agent Drafting Metadata