Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
A negative duration shorter than a second loses its sign in
in_words():The same happens for an interval whose end is less than a second before its start (
'0.12 second'). Longer negative values already keep their sign (test_singular_negative_valuesexpects-1 day). The sub-second branch formattedabs(self.microseconds), andmicrosecondsis the only place the sign is kept for these values.The fix formats
self.microsecondswithoutabs()in bothDuration.in_words()andInterval.in_words(). Positive values and the zero case (0 microseconds) are unchanged.Tests: added
test_negative_subsecondstotests/duration/test_in_words.pyandtests/interval/test_in_words.py. Both fail before the fix and pass after it. The full suite has 1872 passed and 1 failed here, run withPENDULUM_EXTENSIONS=0. The failure istests/test_main.py::test_instance_with_aware_datetime_any_tzinfo, which also fails onmasterin this environment.ruff checkandruff format --check(v0.14.11, the pinned version) pass.I wrote this change with help from an AI assistant. I reviewed it and ran the tests listed above.