[dylanpulver]

start_of_with_invalid_unit and end_of_with_invalid_unit sit between 48 collected tests in tests/datetime/test_start_end_of.py, each with a pytest.raises(ValueError) body, but neither name starts with test_, so pytest never collects them and nothing else in the tree calls them.

def start_of_with_invalid_unit():
    with pytest.raises(ValueError):
        pendulum.now().start_of("invalid")


def end_of_with_invalid_unit():
    with pytest.raises(ValueError):
        pendulum.now().end_of("invalid")

Verification

tests/datetime/test_start_end_of.py goes from 48 to 50 passed.

Both newly collected tests pass, and they are not passing vacuously: replacing "invalid" with a real unit makes the renamed test fail, which confirms the pytest.raises block is doing the work.

tests/datetime/: 573 passed.

[codspeed]

Merging this PR will not alter performance

1 note

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: the symbols of the profiling trace could not be resolved, because no information about the language frames was collected.

See affected benchmarks

✅ 1 untouched benchmark

---

_{Comparing dylanpulver:tests/collect-invalid-unit-tests (5311311) with master (e06dace)}