Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nth_of()currently accepts zero or negative occurrence numbers and returns the first day of the month, quarter or year. That date can even have a different weekday from the one requested:date(2024, 5, 15).nth_of("month", 0, FRIDAY)returns Wednesday, May 1.Route nonpositive occurrences through the existing out-of-range error in both Date and DateTime. Positive occurrences keep their current behavior. The docstrings now make the one-based occurrence numbering explicit.
All 18 new regression cases fail before the change and pass after it. The full test suite has 1,885 passes, 5 skips and the existing timezone-name failure in
test_instance_with_aware_datetime_any_tzinfo, also present on the baseline. Ruff, formatting and mypy on both changed source files pass.This contribution was prepared with Codex assistance.