Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a calendar duration to a Date currently depends on operand order. For example,
date(2024, 1, 31) + duration(months=1)produces February 29, whileduration(months=1) + date(2024, 1, 31)produces March 1.Date inherits the native reflected addition implementation, which uses the duration's approximate day count. Delegate
Date.__radd__to its existing calendar-aware addition, as DateTime already does. The tests cover both signs, leap years, month-end clamping, mixed calendar units, native timedeltas and Date subclasses.Validation: the new tests have 7 failures and 5 passing controls before the change; all 12 pass after it. All 285 Date tests pass. The full suite has 1,879 passes, 5 skips and one existing timezone-name failure in
test_instance_with_aware_datetime_any_tzinfo, also reproduced with the original addition behavior. Ruff, formatting and mypy on the changed source pass.This contribution was prepared with Codex assistance.