Skip to content

Preserve Unicode when serializing relative IRI paths #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dcastroro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve Unicode when serializing relative IRI paths #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/hyperlink/_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,9 @@ def _encode_path_parts(
for part in text_parts
]
else:
encoded_parts = [_encode_schemeless_path_part(text_parts[0])]
encoded_parts = [
_encode_schemeless_path_part(text_parts[0], maximal=maximal)
]
encoded_parts.extend(
[
_encode_path_part(part, maximal=maximal) if part else part
Expand Down
10 changes: 10 additions & 0 deletions src/hyperlink/test/test_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,6 +1344,16 @@ def test_schemeless_path(self):
u6 = URL.from_text(u5.to_text()).to_uri()
assert u5 == u6 # colons stay decoded bc they're not in the first seg

def test_schemeless_iri_path(self):
# type: () -> None
"""Relative IRI paths preserve Unicode while escaping delimiters."""
url = URL(path=("café:menu", "next"))
iri_text = "café%3Amenu/next"
uri_text = "caf%C3%A9%3Amenu/next"
assert url.to_text() == iri_text
assert url.to_uri().to_text() == uri_text
assert URL.from_text(uri_text).to_iri().to_text() == iri_text

def test_emoji_domain(self):
# type: () -> None
"See issue #7, affecting only narrow builds (2.6-3.3)"
Expand Down