Skip to content

Format NaN with the locale's symbol, without fraction digits or exponent #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RavSinghChandan wants to merge 1 commit into from
+17 −3
Closed

Format NaN with the locale's symbol, without fraction digits or exponent #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions babel/numbers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,8 +1525,8 @@ def apply(
if not decimal_quantization or (self.exp_prec and frac_prec == (0, 0)):
frac_prec = (frac_prec[0], max([frac_prec[1], get_decimal_precision(value)]))

# Render scientific notation.
if self.exp_prec:
# Render scientific notation (NaN and infinity have no exponent).
if self.exp_prec and value.is_finite():
number = ''.join([
self._quantize_value(value, locale, frac_prec, group_separator, numbering_system=numbering_system),
get_exponential_symbol(locale, numbering_system=numbering_system),
Expand Down Expand Up @@ -1640,9 +1640,15 @@ def _quantize_value(
*,
numbering_system: Literal["default"] | str,
) -> str:
# If the number is +/-Infinity, we can't quantize it
# If the number is +/-Infinity or NaN, we can't quantize it
if value.is_infinite():
return get_infinity_symbol(locale, numbering_system=numbering_system)
if value.is_nan():
symbols = _get_number_symbols(
Locale.parse(locale or LC_NUMERIC),
numbering_system=numbering_system,
)
return symbols.get('nan', 'NaN')
quantum = get_decimal_quantum(frac_prec[1])
rounded = value.quantize(quantum)
a, sep, b = f"{rounded:f}".partition(".")
Expand Down
8 changes: 8 additions & 0 deletions tests/test_numbers_format_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,14 @@ def test_nan_and_infinity():
assert numbers.format_compact_decimal(decimal.Decimal('NaN'), locale='en_US', format_type="short") == 'NaN'
assert numbers.format_currency(decimal.Decimal('Infinity'), 'USD', locale='en_US') == '$∞'
assert numbers.format_currency(decimal.Decimal('-Infinity'), 'USD', locale='en_US') == '-$∞'
assert numbers.format_currency(decimal.Decimal('NaN'), 'USD', locale='en_US') == '$NaN'
assert numbers.format_currency(decimal.Decimal('NaN'), 'EUR', locale='de_DE') == 'NaN\xa0€'
assert numbers.format_decimal(decimal.Decimal('NaN'), '#,##0.00', locale='en_US') == 'NaN'
assert numbers.format_scientific(decimal.Decimal('NaN'), locale='en_US') == 'NaN'
assert numbers.format_scientific(decimal.Decimal('Infinity'), locale='en_US') == '∞'
# the locale's symbol for NaN is used, like for infinity
assert numbers.format_decimal(decimal.Decimal('NaN'), locale='fi_FI') == 'epäluku'
assert numbers.format_decimal(float('nan'), locale='ar_EG', numbering_system='default') == 'ليس\xa0رقمًا'


def test_group_separator():
Expand Down