Repository navigation
Runtime fixes for pyrevit.forms under CPython (pyRevit #3846) - #4
Draft
romangolev wants to merge 14 commits into
Draft
romangolev wants to merge 14 commits into
romangolev wants to merge 14 commits into
Conversation
Redefinitions that change clrmethod or clrproperty members get a fresh type, and Reset() clears the cache.
Types keep __namespace__.Name so they stay importable; only a differing shape gets a hash suffix.
Interface-only classes fall back to a plain type if generation fails, so imports never break.
A codec that runs Python could deadlock against a thread holding the GIL.
cached_property works, and same-named classes from different scripts no longer share a type.
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review PR for the pythonnet changes behind pyrevitlabs/pyRevit#3846 (
pyrevit.formsunder CPython).pyRevit 7.0.1 pins this fork at
f591d92(the base branch,pyrevit-7). pyrevitlabs/pyRevit#3846 moves thedev/modules/pyRevitLabs.Python.Netsubmodule to173f533and updates the PythonNet DLLs indev/libs. These 13 commits were pushed straight topyrevit-5-main, which already contains them; this PR exists so they can be reviewed and linked from pyrevitlabs/pyRevit#3846.Changes
Derived CLR types
__namespace__; interface types are keyed by defining file.__set_name__,__init_subclass__) run for derived types.Conversions
booltargets.objectmaps toSystem.Objectas a generic argument.with).Codecs
Tests