Repository navigation
Raise NoSuchIdException for unknown device id in SimCore. - #3086
Merged
janiversen merged 1 commit intoNov 11, 2026
Merged
Conversation
Co-authored-by: Claude Opus 5.5 <claude-opus-5.5@claude-cli>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimCore.__get_devicefalls back toself.devices[0]even when no device 0 exists, so an unknown device id raisesKeyErrorand the server answers 0x04. The request handler expectsNoSuchIdException, so it never answers 0x0B, andignore_missing_deviceshas no effect.This restores the old
ModbusServerContextlookup: the id, else device 0, elseNoSuchIdException. Tests added intest_simcore.py.🤖 Generated with Claude Code - reviewed by @restlessronin