Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hosted runners have no GPU, so
test_gpu_matches_cpuis always skipped (cuda_available()is False) and the Mandelbrot kernel is only compiled, never run. This adds a separate, optional workflow.github/workflows/gpu-sim.ymlthat builds the extension and runs the tests on a simulated NVIDIA H100 using PantheonSim (no GPU needed). I am the author of PantheonSim, so please weigh this accordingly.It does not touch the existing workflows and is not meant to be a required check. A simulator cannot reproduce hardware-specific behavior or timing, so it complements real-GPU testing and does not replace it.
What it does:
pip install . --group test, passingCMAKE_CUDA_ARCHITECTURES=90-virtual(the simulator runs the embedded PTX)CMakeLists.txtsetsCUDA_RUNTIME_LIBRARY Staticon the target, so the job changes that one word withsedin its own checkout; the repository files are not modifiedpytest -rs testsundervgpu runmasterthat touchsrc/,tests/,CMakeLists.txtorpyproject.toml, with a concurrency group that cancels superseded runsNotes:
test_gpu_matches_cpu, which compares the GPU image with the CPU image.