Skip to content

Added intended DragonHPC notebooks overwriting placeholders - #4

Merged
applio merged 6 commits into
mainfrom
intended_dragonhpc_notebooks_and_support
Nov 15, 2026
Merged

applio merged 6 commits into
mainfrom
intended_dragonhpc_notebooks_and_support

Conversation

@applio

@applio applio commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Also updated refs in syllabi and READMEs and added solutions for test.

…refs in syllabi and READMEs, added solutions for test.
@applio
applio requested a review from aaronj0 November 13, 2026 22:21
brev/check-notebooks.py --fix sets the python3 kernelspec, the pinned language version and the metadata keys on the four new notebooks, so the Checks workflow passes and test_notebooks.py can start their kernel.

Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>
The PNG was committed as a raw blob although .gitattributes routes *.png through git-lfs; it is now a pointer. The SOLUTION notebook lives one directory down, so its image reference gains a ../ prefix.

Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>
The setup cell gave CUPHOTON_DEMO_REPO a placeholder default, /path/to/checkout/repo/cuPhoton, which disabled the search from the working directory and failed with a path nobody has. The variable is read without a default again, as on main; the image sets it to /opt/cuPhoton.

Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>
The Python cell defaulted CUPHOTON_DEMO_TRANSIENT_CHAIN to 1 while the Bash cell that runs the chain defaulted it to 0, so with the variable unset the chain was skipped and the next cell failed on the missing transient-chain.elapsed. Both cells now default to off, as the prose above them says.

Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>
Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>

@aaronj0 aaronj0 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @applio, this is ready to merge.I've added some minor commits on top surrounding format, LFS and extra shmem requirements in the config.

@applio
applio merged commit 4fa1012 into main Nov 15, 2026
4 checks passed
@aaronj0
aaronj0 deleted the intended_dragonhpc_notebooks_and_support branch November 15, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants