Repository navigation
Added intended DragonHPC notebooks overwriting placeholders - #4
Merged
Merged
Conversation
…refs in syllabi and READMEs, added solutions for test.
brev/check-notebooks.py --fix sets the python3 kernelspec, the pinned language version and the metadata keys on the four new notebooks, so the Checks workflow passes and test_notebooks.py can start their kernel. Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>
The PNG was committed as a raw blob although .gitattributes routes *.png through git-lfs; it is now a pointer. The SOLUTION notebook lives one directory down, so its image reference gains a ../ prefix. Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>
The setup cell gave CUPHOTON_DEMO_REPO a placeholder default, /path/to/checkout/repo/cuPhoton, which disabled the search from the working directory and failed with a path nobody has. The variable is read without a default again, as on main; the image sets it to /opt/cuPhoton. Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>
The Python cell defaulted CUPHOTON_DEMO_TRANSIENT_CHAIN to 1 while the Bash cell that runs the chain defaulted it to 0, so with the variable unset the chain was skipped and the next cell failed on the missing transient-chain.elapsed. Both cells now default to off, as the prose above them says. Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>
Signed-off-by: Aaron Jomy <aaronjomyjoseph@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated refs in syllabi and READMEs and added solutions for test.