Repository navigation
fix(dropwizard5): use locale-independent placeholder keys in GraphiteNamePattern - #2619
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
…NamePattern
extractParameters formatted the "${n}" keys with the default locale, so
under a locale such as ar-EG the keys used Arabic-Indic digits and
CustomLabelMapper left "${0}" unreplaced in mapped names and labels.
Build the keys with string concatenation instead.
Signed-off-by: Sharang Gupta <sharang@sharanggupta.dev>
sharanggupta
requested review from
dhoard,
fstab,
jaydeluca and
zeitlinger
as code owners
October 28, 2026 18:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphiteNamePattern.extractParametersbuilds its placeholder keys withString.format("${%d}", ...), so under a default locale with non-ASCII digits such as ar-EG the first key is${٠}andCustomLabelMapperleaves${0}in the mapped name and labels (app_requests_${0}_totalinstead ofapp_requests_get_total). This builds the keys with string concatenation, which does not depend on the locale, and also covers the dropwizard module since it uses the same mapper. The newGraphiteNamePatternTestcase runs with ar-EG as the default locale and fails without the fix.@zeitlinger