You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds toolchain go1.27.4; the setup action prefers it over the go directive, so CI and releases build with the patched Go. Minimum Go for users stays 1.27.3.
Needs a bump when Go ships a security patch.
Summary by CodeRabbit
Chores
Updated the Go toolchain used to build the application. This is a maintenance-level change to the build environment and does not alter the app’s features or behavior. No other user-visible changes are included in this update.
This change makes builds from the module prefer the patched Go 1.27.4 toolchain, while the minimum Go version for users stays at 1.27.3. No concrete merge-blocking risk was found. The toolchain version will need bumping when Go ships future security patches.
Pre-merge checks: 3 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Linked Issues check
[#2752] The issue requires release binaries to be built with a Go version that includes standard-library security fixes, not the minimum version from the go directive. At head, go.mod sets go 1.27.3…
Provide evidence that projectdiscovery/actions/setup/go@v1 selects the go.mod toolchain line, for example the action source at the pinned version or a release run log showing the Go version used. Alternatively, provide a binary check (for e…
Passed checks: 3 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "chore: build with go1.27.4 toolchain" matches the main change. The go.mod diff adds a toolchain go1.27.4 line, so release and CI builds use the patched Go version. The go directive stays at…
Out of Scope Changes check
The whole-PR diff (merge base 2226531 to head 73faaf7) changes only go.mod, adding two lines: a toolchain go1.27.4 directive. This change directly supports the #2752 objective of building with a pat…
Full details: Title check
Explanation
The title "chore: build with go1.27.4 toolchain" matches the main change. The go.mod diff adds a toolchain go1.27.4 line, so release and CI builds use the patched Go version. The go directive stays at 1.27.3. The title is specific and concise, and it names the change that the linked issue asks for.
Full details: Out of Scope Changes check
Explanation
The whole-PR diff (merge base 2226531 to head 73faaf7) changes only go.mod, adding two lines: a toolchain go1.27.4 directive. This change directly supports the #2752 objective of building with a patched Go toolchain. The go 1.27.3 minimum for users is unchanged, as the PR description states. The change does not alter exported declarations or other code paths. No unrelated changes were found.
Full details: Linked Issues check
Explanation
[#2752] The issue requires release binaries to be built with a Go version that includes standard-library security fixes, not the minimum version from the go directive. At head, go.mod sets go 1.27.3 and adds toolchain go1.27.4. The release workflow (.github/workflows/release.yml) runs projectdiscovery/actions/setup/go@v1 and does not set a Go version itself. The PR states that this action prefers the toolchain line. That action is external to this repository, and its source was not available for inspection. The repository therefore does not show that the release build uses go1.27.4. The go.mod change is the only coding change, and no automated test covers the release build. The requirement is plausibly met but not established.
Resolution
Provide evidence that projectdiscovery/actions/setup/go@v1 selects the go.mod toolchain line, for example the action source at the pinned version or a release run log showing the Go version used. Alternatively, provide a binary check (for example go version -m or govulncheck -mode=binary) on a build produced by the release workflow, showing go1.27.4.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the toolchain line, Go 1.27.4 joins the sign. The language version stays in place, While carrots hop at a steady pace. One small directive marks the trail, And down the burrow speeds the tale.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: a83de2a4-2775-41f2-b4ed-f956f25f074a
Commits
Reviewing files that changed from the base of the PR and between 402fd34 and 73faaf7.
Files selected for processing: 1
go.mod
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2752
Adds
toolchain go1.27.4; the setup action prefers it over thegodirective, so CI and releases build with the patched Go. Minimum Go for users stays 1.27.3.Needs a bump when Go ships a security patch.
Summary by CodeRabbit