Repository navigation
Flat Lighting Compatibility patch - #25
Open
AshenSolYT wants to merge 1 commit into
Open
AshenSolYT wants to merge 1 commit into
AshenSolYT wants to merge 1 commit into
Conversation
Skip directional shading on merged quads when the Flat Lighting mod is installed and when cardinal lighting is off. It only reads only its config file (flat-lighting.json); no Flat Lighting code is ever used. The lighting behavior is unchanged when the mod isn't installed or cardinal lighting is on.
Author
|
@programmer1o1 this is a pretty small patch that fixes a bug with flat lighting |
Author
|
and yes it does work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip directional shading on merged quads when the Flat Lighting mod is installed and when cardinal lighting is off. It only reads only its config file (flat-lighting.json); no Flat Lighting code is ever used. The lighting behavior is unchanged when the mod isn't installed or cardinal lighting is on.
and this is the bug if cardinal lighting is off
ignore the weird terrain it's a custom lod mod