Repository navigation
Conversation
mremond
force-pushed
the
fm/task-0418a43a
branch
from
November 16, 2026 07:57
7a53e23 to
29c96bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reads after case, if and receive branches should count as uses instead of producing false unused-variable warnings.
What changed
Before and after
Before: The existing nested-case fixture produced 21 false unused-variable warnings.
After: The same fixture produces zero unused-variable warnings, while all eleven genuinely unused controls still warn.
This changes compiler diagnostics, not a graphical view; compiler transcripts and native execution verify the result.
Checked
Live validation: Demonstrated for this version. 3 of 3 scenarios driven live in the product.
How it was checked
cargo test --locked -p nera-ir -j 4: 478 unit and 49 integration tests passed.
cargo build --release --locked -j 4; cargo clippy --workspace --all-targets --locked -j 4 -- -D warnings.
cargo test --workspace --locked --no-fail-fast -j 4.
python3 scripts/test-allocator-config.py; NERA_SCHEDULERS=4 ./target/release/nera test -j 1 --timeout 30; python3 scripts/test-stacktrace-order.py.
Ten consecutive runs of all 293 warning tests and the branch_export_warnings native fixture passed without retries.
Direct check/build diagnostics and native program output matched erlc -Wall and OTP 29 on macOS arm64. Independent code review found no remaining defect.
Risk
Risk above low: Blast radius, medium — Warning traversal and shared read collection also feed closure capture analysis.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.