Repository navigation
fix(runtime): dispatch dynamic bitstring BIFs - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dynamic calls to bit_size/1 and is_bitstring/1 raised undef even though direct calls worked.
What changed
Before and after
Before: For an 11-bit input, all three requested dynamic forms raised undef for both functions.
After: Those forms return 11 for bit_size/1 and true for is_bitstring/1, matching BEAM.
This changes native call results, not a screen; real native and BEAM program transcripts demonstrate the behavior.
Checked
Live validation: Demonstrated for this version. 2 of 3 scenarios driven live in the product.
How it was checked
Built the runtime before the compiler with cargo build --release --locked -p nera-runtime and cargo build --release --locked -p nera.
Ran ./target/release/nera test bif_bitstring_dynamic bif_byte_size_dynamic bitstring_size_badarg binary_tail_byte_size -j 1 --timeout 30.
Compiled the new fixture with erlc and ran bif_bitstring_dynamic:test() on BEAM with explicit completion.
Ran the new native fixture ten times consecutively, without retries.
Ran cargo clippy --workspace --all-targets --locked -- -D warnings and cargo test --workspace --locked --no-fail-fast.
Ran python3 scripts/test-allocator-config.py, ./target/release/nera test -j 1 --timeout 30 and python3 scripts/test-stacktrace-order.py.
Local validation used macOS arm64; hosted platform checks are read separately before merge.
Risk
Risk: low in every dimension.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.