Repository navigation
fix(ir): preserve comprehension filter bindings across generators - #62
Merged
Merged
Conversation
mremond
force-pushed
the
fm/task-0b8f75cb
branch
from
November 15, 2026 20:03
735f410 to
530f52b
Compare
mremond
force-pushed
the
fm/task-0b8f75cb
branch
from
November 15, 2026 20:32
530f52b to
520c4da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Filter-bound names must remain available to later comprehension qualifiers and templates, matching Erlang semantics.
What changed
Before and after
Before: The requested comprehension failed compilation instead of producing its single expected result.
After: It now returns [258], and all 48 shared assertions match BEAM with both native scheduler configurations.
This change affects compiler bindings rather than an on-screen view; native and BEAM transcripts demonstrate the behavior.
Checked
Live validation: Demonstrated for this version. 3 of 3 scenarios driven live in the product.
How it was checked
Built the runtime before the compiler with cargo build --release --locked.
Ran the shared Erlang fixture on native default schedulers, NERA_SCHEDULERS=1 and OTP 29.
cargo clippy --workspace --all-targets --locked -- -D warnings
cargo test --workspace --locked --no-fail-fast -- --test-threads=4
nera test -j 1 --timeout 30; python3 scripts/test-allocator-config.py; python3 scripts/test-stacktrace-order.py
Repeated full validation after preserving newer record-default diagnostic context. Local proof ran on macOS arm64; Windows execution was not performed.
Risk
Risk: low in every dimension.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.