Repository navigation
test(ir): cover case exports inside maybe bodies - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Protect case-branch bindings read later in a maybe body from false unbound-variable regressions.
What changed
Before and after
Before: The compiler already accepted these programs, but zero dedicated fixtures covered case exports read later in a maybe body.
After: One shared fixture checks nine outcomes and completion; a diagnostic regression rejects false semantic errors.
Only tests and documentation change; no screen or visible compiler behavior changes.
Checked
Live validation: Demonstrated for this version. 2 of 2 scenarios driven live in the product.
How it was checked
cargo build --release --locked
cargo clippy --workspace --all-targets --locked -- -D warnings
cargo test --workspace --locked --no-fail-fast
cargo test -p nera-ir --locked warnings::tests:: (ten consecutive runs)
./target/release/nera test -j 1 --timeout 30
./target/release/nera test maybe_case_exports -j 1 --timeout 30 (ten consecutive runs)
python3 scripts/test-allocator-config.py; python3 scripts/test-stacktrace-order.py
nera check and nera build with the shared fixture; erlc and erl run the same assertions; native and BEAM stdout match.
Existing false unused-variable warnings remain outside this regression's scope.
Risk
Risk: low in every dimension.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.