Repository navigation
fix(ir): treat comprehension guard filters as guards - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Raising guard-expression filters should reject an element instead of aborting the comprehension.
What changed
Before and after
Before: A list containing two nonempty maps, one empty map and one atom aborted with badmap.
After: The same list returns its two nonempty maps, and its binary comprehension returns <<1,1>>.
This changes native program results, not an application screen; command-output comparisons demonstrate the behavior.
Checked
Live validation: Demonstrated for this version. 2 of 2 scenarios driven live in the product.
How it was checked
cargo build --release --locked -j 4 -p nera-runtime; cargo build --release --locked -j 4
cargo clippy --workspace --all-targets --locked -j 4 -- -D warnings
cargo test --workspace --locked --no-fail-fast -j 4
python3 scripts/test-allocator-config.py; python3 scripts/test-stacktrace-order.py
./target/release/nera test -j 1 --timeout 30
./target/release/nera test comprehension_guard_filter -j 1 --timeout 30, ten consecutive runs; one further run with NERA_SCHEDULERS=1
Compiled and executed the same regression on OTP 29; native and BEAM output probes compared actual results and exception classes.
The source manifest matches all eight committed files; no runtime dependencies or signing material changed.
Risk
Risk: low in every dimension.
Full risk assessment
Pipeline
Updates from git push no-mistakes
Infinitary checked this version: an independent review that also judged the documents, and live validation the review accepted.